We're updating the issue view to help you get more done. 

add check if transform[d]==0

Description

I wonder if we should add a new check for the contrary case – that is, if transform[d]==0, then we might want to assert that the indices are in fact, singleton in dimension ‘d’.

This is related to commit 0cf07c41e3c2a6ef717a9f6e1dc4abb96c9a49a1:

_ Improve error messages, fix error check (fixed)

 

Improved the error messages. The original message for checking for valid range would output something that didn't make sense or at least wasn't helpful. Split this into two checks and output info that helps locate problem.

 

Added `connectname` to error messages to show which connection had issues.

 

The transform check was testing `abs(transform[i]) < 0` which isn't possible so that can be removed. Note that transform[i] can be equal to zero in the null dimension which wasn't recognized in the original pull request.

 

This was originally submitted as #62 which was applied and then reverted by #63. Issues identified in #63 have been addressed in this revision.

 

_

Status

Assignee

Unassigned

Reporter

Scot Breitenfeld

Labels

None

Components

Fix versions

Priority

Minor